Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc FR] — Core concepts adding and translation #905

Merged
merged 12 commits into from
Aug 15, 2017
Merged

Conversation

MachinisteWeb
Copy link
Contributor

@MachinisteWeb MachinisteWeb commented Aug 14, 2017

Hi @posva

We have translated the new « Core Concepts » file.

This PR is ready for merge !

@ktsn
Copy link
Member

ktsn commented Aug 15, 2017

@haeresis Can we revert book.json? Looks like gitbook cannot recognize it since it seems an invalid symbolic link.

@MachinisteWeb
Copy link
Contributor Author

Hi @ktsn

I do not understand exactly the problem. What can I do to change the problem?

Why my full content was replaced by exactly the same full content for « README.md » and « book.json » ?

@ktsn
Copy link
Member

ktsn commented Aug 15, 2017

@haeresis
Hm, I don't know why they are replaced. I just confirm that I cannot serve docs with gitbook locally because of book.json.

When I run yarn docs (or npm run docs), it throws Error: ENOENT: no such file or directory, stat '/.../vuex/docs/fr/book.jsonerror.

So I've checked its file type via ls -l and it shows that book.json is a symbolic link but it points a weird place.

lrwxr-xr-x  1 katashin  staff   392 Aug 15 21:39 book.json -> {?  "gitbook": "2.x.x",?  "plugins": ["edit-link", "prism", "-highlight", "github"],?  "pluginsConfig": {?    "edit-link": {?      "base": "https://github.com/vuejs/vuex/tree/dev/docs",?      "label": "Éditer cette page"?    },?    "github": {?      "url": "https://github.com/vuejs/vuex/"?    }?  },?  "links": {?    "sharing": {?      "facebook": false,?      "twitter": false?    }?  }?}?

Would it be successfully served in your machine?

@MachinisteWeb
Copy link
Contributor Author

Ok. I delete file and re-inject the previous version. Modifications are not present anymore so, I think it's okay.

@ktsn
Copy link
Member

ktsn commented Aug 15, 2017

It works now. Thanks!

@ktsn ktsn merged commit a8c76e4 into vuejs:dev Aug 15, 2017
@MachinisteWeb
Copy link
Contributor Author

Thx to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants