Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] goTo vertical scroll does not work on iOS #6914

Closed
raybog opened this issue Apr 4, 2019 · 4 comments · May be fixed by maxiplux/full-stack-fastapi-couchbase#1
Closed

[Bug Report] goTo vertical scroll does not work on iOS #6914

raybog opened this issue Apr 4, 2019 · 4 comments · May be fixed by maxiplux/full-stack-fastapi-couchbase#1
Assignees
@KaelWD
Labels
E: goTo GoTo composable T: bug Functionality that does not work as intended/expected
Milestone
v1.5-lts

Comments

@raybog
Copy link

raybog commented Apr 4, 2019

Versions and Environment

Vuetify: 1.5.9
Vue: 2.6.10
Browsers: Safari
OS: Mac OS 10.14.3

Steps to reproduce

On iOs device (any browser) or Safari (mac os) click any of the menus (one, two, three).

Expected Behavior

It should scroll, after menu click, vertically to the corresponding IDs

Actual Behavior

It does not scroll on, menu click, on iOs device (any browser) or Safari (mac os).

After scrolling the window down a bit then it works fine.

Reproduction Link

https://ww9nq0kq48.codesandbox.io

Other comments

Found problem in goTo function and sending trough pull request soon.
raybog added a commit to raybog/vuetify that referenced this issue Apr 4, 2019
@raybog
fix vuetifyjs#6914
2023717
@raybog raybog mentioned this issue Apr 4, 2019
Closed
5 tasks
@blalan05 blalan05 added C: Directive S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected labels Apr 10, 2019
@madebycaliper
Copy link

madebycaliper commented Jul 1, 2019 •
edited
Loading

@raybog I've been trying to debug a similar issue. It appears the goTo functionality only breaks if you're at the very top of the iOS safari window. If you move even 1px down, the clicks begin to work.

I tested by opening the XCode Simulator and entering window.scrollTo(0,1) clicking my buttons (and you're codesandbox link) and the scroll works. I also then confirmed there was no scroll after window.scrollTo(0,0) and clicking again. Any updates on the progress of the fix? (I read some of #6915). Any help would be great.

@haliloncen
Copy link

I'm having the same problem. Is there a solution?

@madebycaliper
Copy link

@haliloncen I tried merging some of the code from that PR into my local copy of Vuetify but it didn't seem resolve the issue (might have done it wrong). Because it was time-sensitive for me I just added a reliable package I've worked with before, vue-scrollto, which is very minimal in terms of config/markup.

It's a shame to have to add more code to my vendor.js file but it's working!

@KaelWD KaelWD self-assigned this Jul 26, 2019
@KaelWD KaelWD removed the S: has PR The issue has a pending Pull Request label Jul 26, 2019
@KaelWD KaelWD added this to the v1.5-lts milestone Jul 26, 2019
KaelWD added a commit that referenced this issue Jul 26, 2019
@KaelWD
fix(goTo): get clientHeight from <html> when target is <body>
3f96592 
body.clientHeight === body.scrollHeight in iOS

fixes #6914
@KaelWD KaelWD closed this as completed in 854c826 Jul 26, 2019
@justvr
Copy link

justvr commented Sep 2, 2019

I suppose this is not a solution. This is rather a... workaround...

@snyk-bot snyk-bot mentioned this issue Sep 22, 2019
Open
@johnleider johnleider added E: goTo GoTo composable and removed goTo labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaelWD KaelWD

Labels
E: goTo GoTo composable T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v1.5-lts
8 participants
@madebycaliper @haliloncen @raybog @johnleider @jacekkarczmarczyk @KaelWD @justvr @blalan05