Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField): prevent TypeError when color is an empty string #6982

Merged
merged 2 commits into from
Apr 13, 2019

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Apr 13, 2019

fixes #6981

is coerced to true if VLabel has Boolean

How Has This Been Tested?

lol

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #6982 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6982   +/-   ##
======================================
  Coverage    85.3%   85.3%           
======================================
  Files         298     298           
  Lines        7221    7221           
  Branches     1804    1804           
======================================
  Hits         6160    6160           
  Misses        960     960           
  Partials      101     101
Impacted Files Coverage Δ
packages/vuetify/src/components/VLabel/VLabel.ts 100% <ø> (ø) ⬆️
...kages/vuetify/src/components/VRadioGroup/VRadio.js 100% <ø> (ø) ⬆️
...ckages/vuetify/src/components/VCounter/VCounter.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a8725...391ce6e. Read the comment docs.

@dsseng dsseng merged commit fc6a66b into master Apr 13, 2019
@dsseng dsseng deleted the fix/6981-colorable-empty-typeerror branch April 13, 2019 20:16
@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug report] v-text-field with empty color props
2 participants