Fix setElementContents for outerHTML #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
demiankatz
requested changes
Jan 9, 2025
| if (property !== 'outerHTML') { | ||
| // Set any attributes (N.B. has to be done before scripts in case they rely on the attributes): | ||
| Object.entries(attrs).forEach(([attr, value]) => elm.setAttribute(attr, value)); | ||
| } |
There was a problem hiding this comment.
Should we perhaps add something like:
Suggested change
| } | |
| } else { | |
| console.error("Incompatible parameters passed to setElementContents()."); | |
| } |
...just so there's a bit of feedback if somebody attempts something illegal?
There was a problem hiding this comment.
Yes, but only when the 'attrs' is actually not empty. I added it.
demiankatz
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks, @ThoWagen! Looks good, and all tests are passing on my end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug discovered in #3918