Refactoring RecordDataFormatter spec provision #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks, @ThoWagen -- this is a good idea; see below for a few minor suggestions!
module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatter.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatter.php
Outdated
Show resolved
Hide resolved
module/VuFind/tests/unit-tests/src/VuFindTest/View/Helper/Root/RecordDataFormatterTest.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatterFactory.php
Show resolved
Hide resolved
module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatterFactory.php
Show resolved
Hide resolved
module/VuFind/src/VuFind/RecordDataFormatter/Specs/PluginManager.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/RecordDataFormatter/Specs/DefaultRecord.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/RecordDataFormatter/Specs/DefaultRecord.php
Outdated
Show resolved
Hide resolved
…rd.php Co-authored-by: Demian Katz <[email protected]>
…ing' of github.com:ThoWagen/vufind into pull-request/refactor-record-data-formatter-spec-providing
demiankatz
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks, @ThoWagen, I'm feeling very good about the direction this is taking. I've just left a couple of minor suggestions.
Once you've addressed those (and feel free to ignore any suggestions you don't like -- these ideas are purely optional), I think we should advertise this one on the pr-reviews channel on Slack to get a few more eyes on it, since it's a big and significant change.
module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatterFactory.php
Outdated
Show resolved
Hide resolved
module/VuFind/src/VuFind/View/Helper/Root/RecordDataFormatter.php
Outdated
Show resolved
Hide resolved
demiankatz
added
improvement
architecture
…actory.php Co-authored-by: Demian Katz <[email protected]>
demiankatz
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the definition of RecordDataFormatter specifications from the factory to a new plugin manager. This has the advantage, that the RecordDataFormatter can be used for other RecordDrivers like EDS and that translations are available when defining the specs.
TODO