Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moment fix #72

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Moment fix #72

merged 1 commit into from
Jun 25, 2024

Conversation

jotkauser
Copy link
Contributor

@jotkauser jotkauser commented Jun 25, 2024

Resolves #71

The formats was in lowercase and prevented dateFrom and dateTo from working

@BaderBC
Copy link
Member

BaderBC commented Jun 25, 2024

LGTM

Let us check if it works and we will merge it

@jotkauser
Copy link
Contributor Author

Replace every yyyy-mm-dd basically with YYYY-MM-DD

@BaderBC
Copy link
Member

BaderBC commented Jun 25, 2024

Replace every yyyy-mm-dd basically with YYYY-MM-DD

Believe me or not, but it isn't that hard to understand your 2 lines of code, you don't need to explain :)

Copy link
Member

@maxidragon maxidragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@maxidragon maxidragon merged commit d79787c into vulcan-api:main Jun 25, 2024
1 check passed
@jotkauser
Copy link
Contributor Author

Update it on npmjs too :)

@maxidragon
Copy link
Member

maxidragon commented Jun 25, 2024

New version (3.5.4) will be available on npm in a few minutes

edit: published ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting lessons fails
3 participants