(VDB-929) Use StorageKeyLookup in vDB #244
Conversation
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
go.mod
Outdated
| google.golang.org/appengine v1.6.0 // indirect | ||
| gopkg.in/natefinch/npipe.v2 v2.0.0-20160621034901-c1b8fa8bdcce // indirect | ||
| gopkg.in/urfave/cli.v1 v1.20.0 // indirect | ||
| gopkg.in/urfave/cli.v1 v1.22.1 // indirect |
There was a problem hiding this comment.
Quick word on the deps here: these were added as a result of getting a specific branch of vDB. Happy to try and prune it down a bit but I'm also tempted to kick the can down the road to right before we cut a release (i.e. verifying dependencies match across repos when pre-building the plugin)
There was a problem hiding this comment.
I'm not 100% sure about updating that pesky urfave/cli to 1.22.1 - in vdb I think we still have it as 1.20.0. I was previously seeing issues when using a more recent version than this, but perhaps that's changed?
There was a problem hiding this comment.
Fair enough - will bump that back down
There was a problem hiding this comment.
interestingly, when I change the version, it just gets removed entirely from the go.mod file in the build 🤔
Going to push that up, but I think this could be an interesting scenario for our dep resolver at release time
rmulhol
force-pushed
the
vdb-929-move-shared-files-to-vdb
branch
from
bf131d9 to
6ba26ec
Compare
go.mod
Outdated
| google.golang.org/appengine v1.6.0 // indirect | ||
| gopkg.in/natefinch/npipe.v2 v2.0.0-20160621034901-c1b8fa8bdcce // indirect | ||
| gopkg.in/urfave/cli.v1 v1.20.0 // indirect | ||
| gopkg.in/urfave/cli.v1 v1.22.1 // indirect |
There was a problem hiding this comment.
I'm not 100% sure about updating that pesky urfave/cli to 1.22.1 - in vdb I think we still have it as 1.20.0. I was previously seeing issues when using a more recent version than this, but perhaps that's changed?
| @@ -26,15 +26,15 @@ import ( | |||
| mcdStorage "github.com/vulcanize/mcd_transformers/transformers/storage" | |||
| "github.com/vulcanize/mcd_transformers/transformers/storage/flip" | |||
| "github.com/vulcanize/mcd_transformers/transformers/storage/test_helpers" | |||
| "github.com/vulcanize/vulcanizedb/libraries/shared/storage" | |||
| storage2 "github.com/vulcanize/vulcanizedb/libraries/shared/factories/storage" | |||
There was a problem hiding this comment.
Super small, but it looks like this could be storage (instead of storage2) since we're aliasing the other storage package to mcdStorage. Totally not merge blocking!
Companion PR to vulcanize/vulcanizedb#163