VDB-963 cat file flip #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
requested review from
rmulhol,
Gslaughl,
yaoandrew and
m0ar
elizabethengelman
force-pushed
the
vdb-963-cat-file-flip
branch
from
67e2a51 to
90c08cd
Compare
rmulhol
approved these changes
Nov 1, 2019
| @@ -17,6 +17,7 @@ | |||
| package queries | |||
|
|
|||
| import ( | |||
| "github.com/vulcanize/vulcanizedb/libraries/shared/factories/event" | |||
There was a problem hiding this comment.
discovered a new trick (don't know how it took me this long...): goimports -w <dir>
Don't need to apply it to these files as part of this PR, but I'd love to add that to make test + CI so that we can stop worrying about where the imports are going
| @@ -88,10 +89,12 @@ var _ = Describe("Ilk File Events Query", func() { | |||
|
|
|||
| catFileFlipLog := test_data.CreateTestLog(headerOneId, db) | |||
| catFileFlip := test_data.CatFileFlipModel() | |||
| catFileFlip.ForeignKeyValues[constants.IlkFK] = test_helpers.FakeIlk.Hex | |||
| ilkId, createIlkError := shared.GetOrCreateIlk(test_helpers.FakeIlk.Hex, db) | |||
There was a problem hiding this comment.
really minor, but golint seems to prefer ID to Id and I'm tempted to follow that for all new code with the eventual goal of silencing the linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.