This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Plugin updates #113
Merged
Plugin updates #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmulhol
commented
Jun 27, 2019
rmulhol
commented
- Emit specific errors with custom errors when execution fails
- Put tmp directories inside vdb directory (so we don't need permissions outside of it for execution)
- Call goose via library rather than binary (so we don't need the binary in the execution environment)
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
yaoandrew
reviewed
Jun 27, 2019
cmd/root.go
Outdated
| fmt.Println("Error: ", invalidConfigError) | ||
| log.Fatal(invalidConfigError) | ||
| formattedError := fmt.Sprintf("%s: %s", invalidConfigError, err.Error()) | ||
| log.Fatal(formattedError) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Not a big deal, but log.Fatal calls os.Exit(1) so you can lose this line.
There was a problem hiding this comment.
I'll just rebase on your PR :D
yaoandrew
approved these changes
Jun 27, 2019
- include actual error to highlight the specific issue
- include specific error
- enable separator between home and migrations dir
- Removes dependency on goose binary existing in plugin execution environment
m0ar
reviewed
Jun 28, 2019
| mkdirErr := os.Mkdir(m.tmpMigDir, os.FileMode(os.ModePerm)) | ||
| if mkdirErr != nil { | ||
| mkdirErrString := "unable to create temporary migration directory %s: %s" | ||
| return errors.New(fmt.Sprintf(mkdirErrString, m.tmpMigDir, mkdirErr.Error())) |
There was a problem hiding this comment.
fmt.Errorf fyi, saves you a trip to the Sprintf :)
|
@rmulhol Late to the party, but great fixes! Especially nice with more expressive error messages 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.