Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed firewall support for VKE #277

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Byteflux
Copy link
Contributor

@Byteflux Byteflux commented Nov 8, 2023

Description

Adds support for the firewall_group_id field that is now returned as part of VKE cluster responses.

Additionally adds support for enable_firewall which can be provided when creating a new VKE cluster. When enabled, a Firewall Group will be deployed and managed by the cluster, ensuring worker nodes are automatically linked to the firewall.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@Byteflux Byteflux requested a review from optik-aper November 8, 2023 21:03
@optik-aper optik-aper added the enhancement New feature or request label Nov 8, 2023
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API doesn't seem to return anything in firewall_group but govultr pulls it in and sends out enable_firewall so I think this is working.

image

@optik-aper optik-aper merged commit 4a9cf4e into vultr:master Nov 9, 2023
6 checks passed
@optik-aper optik-aper mentioned this pull request Nov 10, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants