Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for v2 instance creation types #106

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Fix for v2 instance creation types #106

merged 3 commits into from
Feb 16, 2021

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Feb 12, 2021

Description

With API v2 there was a change that no longer requires the passing of os_id with snapshot, app, or iso.

Packer was still adding in the corresponding os_id with the other types so this PR will remove that.

I tested creation of snapshot, app, os, and iso independently. @Oogy you mind going through these builds also.

Related Issues

fixes #105

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko requested a review from Oogy February 12, 2021 19:50
@ddymko ddymko merged commit 28407c1 into master Feb 16, 2021
@ddymko ddymko deleted the v2-os-changes branch February 16, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants