Exec detach #155
Merged
Exec detach #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vv9k
requested changes
Mar 14, 2023
Co-authored-by: Wojciech Kępka <[email protected]>
|
Thanks for your suggestions :) I applied them and updated the changelog. |
vv9k
reviewed
Mar 14, 2023
|
LGTM, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
A fix for Exec::start() that expected the connection to be upgraded to TCP stream unconditionally.
How did you verify your change:
I use it in my project and it passes existing tests and an additional test specifically made to check my change (container_exec_detach).