Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Elasticsearch 7.9.0 #285

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Upgrade to Elasticsearch 7.9.0 #285

merged 1 commit into from
Aug 19, 2020

Conversation

DustinChaloupka
Copy link
Contributor

Fixes #284

A try at updating for Elasticsearch 7.9.0. Was able to run the tests in the README, but had to upgrade to Gradle 6.6.0 after running into:

✗ docker run -v $(pwd):/home/gradle gradle:6.2.1-jdk13 su gradle -c 'gradle check'
Unable to find image 'gradle:6.2.1-jdk13' locally
6.2.1-jdk13: Pulling from library/gradle
423ae2b273f4: Pull complete
de83a2304fa1: Pull complete
f9a83bce3af0: Pull complete
b6b53be908de: Pull complete
d6eb45629ecf: Pull complete
9c4bc8753daf: Pull complete
af6d9eabc40c: Pull complete
f3f57dc5eea8: Pull complete
47878241187b: Pull complete
Digest: sha256:d85e7236ec4ef948eef1c6b05c7da74f923039f1c9781f1c61147f7ebb09d262
Status: Downloaded newer image for gradle:6.2.1-jdk13

Welcome to Gradle 6.2.1!

Here are the highlights of this release:
 - Dependency checksum and signature verification
 - Shareable read-only dependency cache
 - Documentation links in deprecation messages

For more details see https://docs.gradle.org/6.2.1/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file '/home/gradle/build.gradle' line: 31

* What went wrong:
A problem occurred evaluating root project 'prometheus-exporter'.
> Failed to apply plugin [class 'org.elasticsearch.gradle.info.GlobalBuildInfoPlugin']
   > Gradle 6.5+ is required

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 15s

And then on top of that, Gradle did not have a jdk13 version for anything above 6.5, so it's using jdk14. Unsure if these things are fine or not, or even what to check other than running the tests.

The only other interesting bit was that 7.9.0 added indexing pressure metrics that I was interested in, but am unsure if testing for those should be set up or if they even will show up in the prometheus metrics endpoint.

Copy link
Owner

@vvanholl vvanholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvanholl vvanholl merged commit 40b03d7 into vvanholl:master Aug 19, 2020
@DustinChaloupka DustinChaloupka deleted the es-7.9.0 branch August 19, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release for ES 7.9.0
2 participants