-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enables listener on 1883 #5
Conversation
config/mosquitto.conf
Outdated
@@ -1,7 +1,8 @@ | |||
listener 1883 | |||
persistence true | |||
persistence_location /mosquitto/data/ | |||
log_dest file /mosquitto/log/mosquitto.log | |||
|
|||
## Authentication ## | |||
# allow_anonymous false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question(non-blocking): Not sure, but it seems that since version 2 we also have to set allow_anonymous
to true
explicitely... No?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, starting with mosquitto 2.0 users have to explicitly allow anonimous connections. It's a security reason, and I think we should keep with the "allow_anonymous false" standard, maybe create a comment to warn users about it and how to enable it. Something like:
## Authentication ##
# By default, Mosquitto >=2.0 blocks allow_anonymous authentication. Uncomment the next line to allow it.
# allow_anonymous true
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, maybe the best thing is to enable authentication by default (like it works today with the admin/password login). And update the documentation saying that it is not optional but it is the default behaviour...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Authentication ##
# By default, Mosquitto >=2.0 allows only authenticated connections. Change to true to enable anonymous connections.
allow_anonymous false
like this?
Maybe we should add to the documentation (or a cmd/shell file) on how to update the password?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Authentication ## # By default, Mosquitto >=2.0 allows only authenticated connections. Change to true to enable anonymous connections. allow_anonymous false
like this? Maybe we should add to the documentation (or a cmd/shell file) on how to update the password?
Yes, this seems great!
About password change, I wrote this in the readme, but maybe it should be more explicit?
⛔ Issue(blocking): As discussed in #1 we have to freeze the docker version to |
The added listener can be used with both versions I think. Its a default listener on 1.x and enables "clear text" communication on 2.0. Do you want me to add it in this PR? |
I was referring to this reply where I proposed to have:
|
fixes #1
recreated since #2 was closed by accident.