Allow customizing trace quality menu title (jaegertracing#592)

* Allow customizing Quality Metrics menu title Signed-off-by: Yuri Shkuro <[email protected]> * Change default title Signed-off-by: Yuri Shkuro <[email protected]> * Move defaults Signed-off-by: Yuri Shkuro <[email protected]> * prettier Signed-off-by: Yuri Shkuro <[email protected]> * comment Signed-off-by: Yuri Shkuro <[email protected]> * default Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar · Jun 10, 2020 · 084624d · 084624d
1 parent e7aa715
commit 084624d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/packages/jaeger-ui/src/components/App/TopNav.tsx b/packages/jaeger-ui/src/components/App/TopNav.tsx
@@ -64,7 +64,7 @@ if (getConfigValue('qualityMetrics.menuEnabled')) {
   NAV_LINKS.push({
     to: qualityMetrics.getUrl(),
     matches: qualityMetrics.matches,
-    text: 'Quality Metrics',
+    text: getConfigValue('qualityMetrics.menuLabel'),
   });
 }
 

diff --git a/packages/jaeger-ui/src/constants/default-config.tsx b/packages/jaeger-ui/src/constants/default-config.tsx
@@ -25,6 +25,10 @@ export default deepFreeze(
         menuEnabled: true,
       },
       linkPatterns: [],
+      qualityMetrics: {
+        menuEnabled: false,
+        menuLabel: 'Trace Quality',
+      },
       menu: [
         {
           label: 'About Jaeger',

diff --git a/packages/jaeger-ui/src/types/config.tsx b/packages/jaeger-ui/src/types/config.tsx
@@ -38,6 +38,7 @@ export type LinkPatternsConfig = {
   text: string;
 };
 
+// Default values are provided in packages/jaeger-ui/src/constants/default-config.tsx
 export type Config = {
   archiveEnabled?: boolean;
   deepDependencies?: {
@@ -48,6 +49,7 @@ export type Config = {
   pathAgnosticDecorations?: TPathAgnosticDecorationSchema[];
   qualityMetrics?: {
     menuEnabled?: boolean;
+    menuLabel?: string;
   };
   search?: { maxLookback: { label: string; value: string }; maxLimit: number };
   scripts?: TScript[];