configverify: T6642: verify_interface_exists requires config_dict arg #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
jestabro
force-pushed
the
verify-interface-exists-config
branch
from
81b7917 to
1bc7947
Compare
jestabro
requested review from
dmbaturin,
sarthurdev,
zdc,
sever-sever,
c-po and
fett0
c-po
approved these changes
Aug 10, 2024
sever-sever
approved these changes
Aug 12, 2024
The function verify_interface_exists requires a reference to the ambient config_dict rather than creating an instance. As access is required to the 'interfaces' path, provide as attribute of class ConfigDict, so as not to confuse path searches of script-specific config_dict instances.
jestabro
force-pushed
the
verify-interface-exists-config
branch
from
1bc7947 to
5f23b72
Compare
|
✅ No issues found in unused-imports check.. Please refer the workflow run |
|
@Mergifyio backport circinus |
✅ Backports have been created
|
12 tasks
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The function
verify_interface_existsrequires access to the ambientconfig_dict, rather than its own instantiation usingConfigTreeQuery, in order to get the correct working config representation under configd and at boot. Including the root path 'interfaces' for the syntactical verification test as a config_dict key similar to the case ofwith_pkiwould interfere with script-specific path searches (e.g.interfaces_bonding.py); consequently, the dict of path 'interfaces' is included as an attribute of the classConfigDict.This construction appears redundant in the case of, say,
interfaces_ethernet.py, but is of the right generality to cover all cases.Types of changes
Related Task(s)
Related PR(s)
#3960
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: