Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T4974: add proper dependency on openvpn-dco #4029

Merged
merged 1 commit into from
Sep 5, 2024
Merged

T4974: add proper dependency on openvpn-dco #4029

merged 1 commit into from
Sep 5, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Sep 5, 2024

Change Summary

OpenVPN DCO requires a kernel module, but there is no dependency in this package

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner September 5, 2024 05:21
@c-po c-po mentioned this pull request Sep 5, 2024
Merged
11 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit 2bb8583 into vyos:current Sep 5, 2024
13 of 15 checks passed
@c-po c-po deleted the openvpn-dco branch September 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev sarthurdev approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c-po @dmbaturin @sarthurdev @sever-sever