Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethtool: T6729: drop text based feature parsing in favour of JSON #4094

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Sep 21, 2024

Change Summary

Recent ethtool 6.10 supports JSON output for the base driver features. Remove our old text based processing code and use the machine readable output of ethtool.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

vyos.ethtool

How to test

from vyos.ethtool import Ethtool
eth0 = Ethtool('eth0')
eth0.check_speed_duplex('1000', 'full')
eth0.check_speed_duplex('auto', 'auto')

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Recent ethtool 6.10 supports JSON output for the base driver features. Remove
our old text based processing code and use the machine readable output of
ethtool.
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit 644a91e into vyos:current Sep 22, 2024
15 of 17 checks passed
@c-po c-po deleted the ethtool branch September 22, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants