-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validators: T6739: fix ipaddrcheck argument quoting #4099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmbaturin
requested review from
sarthurdev,
zdc,
jestabro,
sever-sever,
c-po and
fett0
September 25, 2024 15:54
👍 |
✅ No issues found in unused-imports check.. Please refer the workflow run |
jestabro
approved these changes
Sep 25, 2024
c-po
approved these changes
Sep 26, 2024
@Mergifyio backport circinus sagitta |
✅ Backports have been created
|
This was referenced Sep 26, 2024
@dmbaturin smoketests report:
and it was missed here https://github.com/vyos/vyos-1x/actions/runs/11036683938/job/30656416756#step:5:1522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Properly quote
ipaddrcheck
arguments in validator scripts to ensure they are handled correctly if they contain whitespace. Right now such arguments are correctly rejected but result in confusing error messages that contain ipaddrcheck's help:Types of changes
Component(s) name
Validators.
How to test
Smoketest result
Checklist: