Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6757: Openconnect: fix template for correct config parsing while configuring source address for radius authentication. #4120

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

nicolas-fort
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

openconnect

Proposed changes

How to test

Config:

vyos@ocserv-bug:~$ show config comm | grep radius
set vpn openconnect authentication mode radius
set vpn openconnect authentication radius groupconfig 'PPP'
set vpn openconnect authentication radius server 192.168.77.199
set vpn openconnect authentication radius source-address '10.99.99.99'
set vpn openconnect authentication radius timeout '5'
vyos@ocserv-bug:~$

And config file /run/ocserv/radiusclient.conf:

vyos@ocserv-bug:~$ cat /run/ocserv/radiusclient.conf 
### generated by vpn_openconnect.py ###
nas-identifier VyOS

#### Accounting

#### Authentication
authserver 192.168.77.199:1812
radius_timeout 5
bindaddr 10.99.99.99
...


Smoketest result

test_vpn_openconnect.py --> OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

…figuring source address for radius authentication.
Copy link

github-actions bot commented Oct 2, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Oct 2, 2024

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also backport to circinus?

@dmbaturin dmbaturin merged commit 320de31 into vyos:current Oct 3, 2024
17 checks passed
@nicolas-fort
Copy link
Contributor Author

Also backport to circinus?

Yes, and also to Sagitta

@sever-sever
Copy link
Member

I'd stop backports to sagitta now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants