Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6753: Fix json output for mtr / monitor traceroute #4122

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

natali-rs1985
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

op-mode

Proposed changes

How to test

vyos@vyos:~$ mtr 192.0.2.1 json
{
    "report": {
        "mtr": {
            "src": "vyos",
            "dst": "192.0.2.1",
            "tos": 0,
            "tests": 10,
            "psize": "64",
            "bitpattern": "0x00"
        },
        "hubs": [
            {
                "count": 1,
                "host": "192.0.2.14",
                "Loss%": 20.0,
                "Snt": 10,
                "Last": 2221.4,
                "Avg": 1650.2,
                "Best": 491.46,
                "Wrst": 3053.6,
                "StDev": 892.57
            }
        ]
    }
}

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Oct 2, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Oct 2, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

Copy link

github-actions bot commented Oct 4, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever sever-sever merged commit 17c9b44 into vyos:current Oct 5, 2024
15 of 17 checks passed
@fett0
Copy link
Contributor

fett0 commented Oct 5, 2024

Can we backport to saggitta @c-po @sever-sever , I've tested on 1.5:

mtr www.google.com tcp port 443 json
{
    "report": {
        "mtr": {
            "src": "vyos",
            "dst": "www.google.com",
            "tos": 0,
            "tests": 10,
            "psize": "64",
            "bitpattern": "0x00"
        },
        "hubs": [
            {
                "count": 1,
                "host": "172.16.50.1",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 0.942,
                "Avg": 0.831,
                "Best": 0.622,
                "Wrst": 1.144,
                "StDev": 0.18
            },
            {
                "count": 2,
                "host": "192.168.0.1",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 1.33,
                "Avg": 1.132,
                "Best": 0.926,
                "Wrst": 1.447,
                "StDev": 0.182
            },
            {
                "count": 3,
                "host": "200.51.241.1",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 4.281,
                "Avg": 6.549,
                "Best": 3.868,
                "Wrst": 15.751,
                "StDev": 3.841
            },
            {
                "count": 4,
                "host": "74.125.32.151",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 16.592,
                "Avg": 7.961,
                "Best": 3.871,
                "Wrst": 17.839,
                "StDev": 5.241
            },
            {
                "count": 5,
                "host": "72.14.208.90",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 3.431,
                "Avg": 5.362,
                "Best": 3.431,
                "Wrst": 10.078,
                "StDev": 2.425
            },
            {
                "count": 6,
                "host": "108.170.255.29",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 4.561,
                "Avg": 5.326,
                "Best": 4.561,
                "Wrst": 6.821,
                "StDev": 0.705
            },
            {
                "count": 7,
                "host": "142.251.77.171",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 4.811,
                "Avg": 4.541,
                "Best": 3.898,
                "Wrst": 5.306,
                "StDev": 0.503
            },
            {
                "count": 8,
                "host": "eze10s02-in-f4.1e100.net",
                "Loss%": 0.0,
                "Snt": 10,
                "Last": 4.55,
                "Avg": 4.296,
                "Best": 3.59,
                "Wrst": 4.81,
                "StDev": 0.336
            }
        ]
    }
}

@sever-sever
Copy link
Member

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Oct 8, 2024

backport circinus

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 8, 2024
sever-sever pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants