Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6761: Add timeout for OSPF smoketest fail #4125

Merged
merged 1 commit into from
Oct 4, 2024
Merged

T6761: Add timeout for OSPF smoketest fail #4125

merged 1 commit into from
Oct 4, 2024

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Oct 3, 2024 •
edited
Loading

Change Summary

From time to time the smoektest script checks frrconfig to early.
I.e. FRR does not fully load the config during checking or the OSPF daemon is not started at the time of checking.

tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

vyos@r14:~$ /usr/libexec/vyos/tests/smoke/cli/test_protocols_ospf.py
test_ospf_01_defaults (__main__.TestProtocolsOSPF.test_ospf_01_defaults) ... ok
test_ospf_02_simple (__main__.TestProtocolsOSPF.test_ospf_02_simple) ... ok
test_ospf_03_access_list (__main__.TestProtocolsOSPF.test_ospf_03_access_list) ... ok
test_ospf_04_default_originate (__main__.TestProtocolsOSPF.test_ospf_04_default_originate) ... ok
test_ospf_05_options (__main__.TestProtocolsOSPF.test_ospf_05_options) ... ok
test_ospf_06_neighbor (__main__.TestProtocolsOSPF.test_ospf_06_neighbor) ... ok
test_ospf_07_redistribute (__main__.TestProtocolsOSPF.test_ospf_07_redistribute) ... ok
test_ospf_08_virtual_link (__main__.TestProtocolsOSPF.test_ospf_08_virtual_link) ... ok
test_ospf_09_interface_configuration (__main__.TestProtocolsOSPF.test_ospf_09_interface_configuration) ... ok
test_ospf_11_interface_area (__main__.TestProtocolsOSPF.test_ospf_11_interface_area) ... ok
test_ospf_12_vrfs (__main__.TestProtocolsOSPF.test_ospf_12_vrfs) ... ok
test_ospf_13_export_list (__main__.TestProtocolsOSPF.test_ospf_13_export_list) ... ok
test_ospf_14_segment_routing_configuration (__main__.TestProtocolsOSPF.test_ospf_14_segment_routing_configuration) ... ok
test_ospf_15_ldp_sync (__main__.TestProtocolsOSPF.test_ospf_15_ldp_sync) ... ok
test_ospf_16_graceful_restart (__main__.TestProtocolsOSPF.test_ospf_16_graceful_restart) ... ok
test_ospf_17_duplicate_area_network (__main__.TestProtocolsOSPF.test_ospf_17_duplicate_area_network) ... ok

----------------------------------------------------------------------
Ran 16 tests in 76.147s

OK
vyos@r14:~$

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sever-sever
T6761: Add timeout for OSPF smoketest fail
23e4ab6 
From time to time the smoektest script checks frrconfig to early.
I.e. FRR does not fully load the config during checking or the OSPF
daemon is not started at the time of checking.
@sever-sever sever-sever requested a review from a team as a code owner October 3, 2024 17:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

c-po
c-po approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last time I've encountered such a random issue it was actually a FRR bug FRRouting/frr#16376. Tests passing and failing randomly is usually related to undefined states in C/C++ code or improper initialisation/re-initialisation of variables.

Lets see if this helps us - also with FRR 10.1 upgrade on the road.

@c-po c-po merged commit a305ebb into vyos:current Oct 4, 2024
16 of 18 checks passed
@sever-sever
Copy link
Member Author

The last time I've encountered such a random issue it was actually a FRR bug FRRouting/frr#16376. Tests passing and failing randomly is usually related to undefined states in C/C++ code or improper initialisation/re-initialisation of variables.

Lets see if this helps us - also with FRR 10.1 upgrade on the road.

We still get fails

 DEBUG - test_ospf_17_duplicate_area_network (__main__.TestProtocolsOSPF.test_ospf_17_duplicate_area_network) ... FAIL
DEBUG - 
DEBUG - ======================================================================
DEBUG - FAIL: test_ospf_17_duplicate_area_network (__main__.TestProtocolsOSPF.test_ospf_17_duplicate_area_network)
DEBUG - ----------------------------------------------------------------------
DEBUG - Traceback (most recent call last):
DEBUG -   File "/usr/libexec/vyos/tests/smoke/cli/test_protocols_ospf.py", line 578, in test_ospf_17_duplicate_area_network
DEBUG -     self.assertIn(f'router ospf', frrconfig)
DEBUG - AssertionError: 'router ospf' not found in ''
DEBUG - 
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 16 tests in 147.842s

@sever-sever
Copy link
Member Author

Strange but still fails

DEBUG - ======================================================================
DEBUG - FAIL: test_ospf_17_duplicate_area_network (main.TestProtocolsOSPF.test_ospf_17_duplicate_area_network)
DEBUG - ----------------------------------------------------------------------
DEBUG - Traceback (most recent call last):
DEBUG - File "/usr/libexec/vyos/tests/smoke/cli/test_protocols_ospf.py", line 578, in test_ospf_17_duplicate_area_network
DEBUG - self.assertIn(f'router ospf', frrconfig)
DEBUG - AssertionError: 'router ospf' not found in ''
DEBUG -
DEBUG - ----------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 was automatically assigned from vyos/reviewers

Assignees

@sever-sever sever-sever

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sever-sever @jestabro @c-po