Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian: T973: add missing dependency on node-exporter package #4130

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Oct 5, 2024

Change Summary

Extend commit a0c15a1 ("T973: add basic node_exporter implementation") by adding the required dependency to install node-exporter binary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Extend commit a0c15a1 ("T973: add basic node_exporter implementation") by
adding the required dependency to install node-exporter binary.
@c-po c-po requested a review from a team as a code owner October 5, 2024 08:18
Copy link

github-actions bot commented Oct 5, 2024

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit ed873d8 into vyos:current Oct 5, 2024
12 checks passed
@c-po c-po deleted the node-exporter-fix branch October 5, 2024 08:29
Copy link

github-actions bot commented Oct 5, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants