Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo: T6926: remove spam messages to syslog #4212

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 1, 2024

Right now every command that's executed via op-mode/conf-mode is logged with a session entry/exit and command execution into syslog.

sudo[1082396]:      vyos : TTY=pts/1 ; PWD=/home/vyos ; USER=root ; COMMAND=/usr/bin/mv /tmp/config.boot.1082388 /opt/vyatta/etc/config/archive/config.boot
sudo[1082396]: pam_unix(sudo:session): session opened for user root(uid=0) by vyos(uid=1002)
sudo[1082396]: pam_unix(sudo:session): session closed for user root
sudo[1082399]:      vyos : TTY=pts/1 ; PWD=/home/vyos ; USER=root ; COMMAND=/usr/sbin/logrotate -f -s /opt/vyatta/etc/config/archive/lr.state /opt/vyatta/etc/config/archive/lr.conf
sudo[1082399]: pam_unix(sudo:session): session opened for user root(uid=0) by vyos(uid=1002)
sudo[1082399]: pam_unix(sudo:session): session closed for user root

This heavily bloats remote logging services - remove the log entries

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): remove logging noise

Related Task(s)

Related PR(s)

Component(s) name

sudo

Proposed changes

No longer log session information and executed script to syslog

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Right now every command that's executed via op-mode/conf-mode is logged with a
session entry/exit and command execution into syslog.

sudo[1082396]:      vyos : TTY=pts/1 ; PWD=/home/vyos ; USER=root ; COMMAND=/usr/bin/mv /tmp/config.boot.1082388 /opt/vyatta/etc/config/archive/config.boot
sudo[1082396]: pam_unix(sudo:session): session opened for user root(uid=0) by vyos(uid=1002)
sudo[1082396]: pam_unix(sudo:session): session closed for user root
sudo[1082399]:      vyos : TTY=pts/1 ; PWD=/home/vyos ; USER=root ; COMMAND=/usr/sbin/logrotate -f -s /opt/vyatta/etc/config/archive/lr.state /opt/vyatta/etc/config/archive/lr.conf
sudo[1082399]: pam_unix(sudo:session): session opened for user root(uid=0) by vyos(uid=1002)
sudo[1082399]: pam_unix(sudo:session): session closed for user root

This heavily bloats remote logging services - remove the log entries
@c-po c-po requested a review from a team as a code owner December 1, 2024 11:46
Copy link

github-actions bot commented Dec 1, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Dec 1, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • RAID1 tests ❌ failed
  • TPM tests ❌ failed

@dmbaturin dmbaturin merged commit c887126 into vyos:current Dec 2, 2024
15 of 16 checks passed
@c-po c-po deleted the T6926-sudo branch December 2, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants