Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: T3664: fix regression and bug in build script clone of vyos-1x repo #590

Merged
merged 1 commit into from
May 3, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented May 3, 2024

This fixes a regression and a bug introduced in PR #585: the regression was dropping the keyword argument search_parent_directories=True in the initialization of the main (vyos-build) git repo; the bug was that re-running the build script with artifacts of a previous build would throw an error from the git clone of vyos-1x.

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this May 3, 2024
@jestabro jestabro requested review from dmbaturin and sever-sever May 3, 2024 20:15
@github-actions github-actions bot added the current VyOS rolling release label May 3, 2024
@jestabro jestabro merged commit 4490b2a into vyos:current May 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

2 participants