Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: T3664: include build flavor name in the version file #605

Merged
merged 1 commit into from
May 9, 2024
Merged

build: T3664: include build flavor name in the version file #605

merged 1 commit into from
May 9, 2024

Conversation

dmbaturin
Copy link
Member

Change Summary

Right now, version data doesn't include flavor. If we include it, we can add a warning to add system image when the user tries to upgrade to a non-matching flavor, and also improve the update checker to suggest the correct flavor link.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Build scripts.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions github-actions bot added the current VyOS rolling release label May 8, 2024
@c-po
Copy link
Member

c-po commented May 9, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented May 9, 2024

backport sagitta

✅ Backports have been created

@c-po c-po requested review from a team, sarthurdev, zdc, jestabro and sever-sever and removed request for a team May 9, 2024 14:13
@c-po c-po merged commit c58c5cc into vyos:current May 9, 2024
4 of 5 checks passed
dmbaturin added a commit that referenced this pull request May 9, 2024
build: T3664: include build flavor name in the version file (backport #605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

2 participants