Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6406: enables container cpu limits #643

Merged
merged 1 commit into from
May 27, 2024
Merged

T6406: enables container cpu limits #643

merged 1 commit into from
May 27, 2024

Conversation

nvollmar
Copy link
Contributor

Change Summary

Enable the kernel configs to allow CPU container limits

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6406

Component(s) name

kernel

Proposed changes

Enabling the following kernel configs to get cpu/cpuset cgroup controllers available for container cpu limits:

CONFIG_CGROUP_SCHED=y
CONFIG_CGROUP_CPUACCT=y
CONFIG_CPUSETS=y

How to test

Create image with the new configuration and run:

vyos@vyos:~$ cat /sys/fs/cgroup/cgroup.controllers
cpuset cpu memory pids

Current configuration is missing cpuset cpu

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@nvollmar nvollmar requested a review from a team as a code owner May 27, 2024 08:57
@nvollmar nvollmar requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team May 27, 2024 08:57
@github-actions github-actions bot added the current VyOS rolling release label May 27, 2024
@c-po
Copy link
Member

c-po commented May 27, 2024

Please add another PR adding tests for the new Kernel options. Example: vyos/vyos-1x#3522

@nvollmar
Copy link
Contributor Author

Thanks for the hint, will note that down for the config feature implementation

@c-po c-po merged commit b809886 into vyos:current May 27, 2024
8 checks passed
@c-po
Copy link
Member

c-po commented May 27, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented May 27, 2024

backport sagitta

✅ Backports have been created

@nvollmar nvollmar deleted the T6406 branch May 27, 2024 11:23
c-po added a commit that referenced this pull request May 27, 2024
T6406: enables container cpu limits (backport #643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

3 participants