Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6666: singular image_format in flavor files #738

Merged
merged 1 commit into from
Aug 22, 2024
Merged

build: T6666: singular image_format in flavor files #738

merged 1 commit into from
Aug 22, 2024

Conversation

bk2zsto
Copy link
Contributor

@bk2zsto bk2zsto commented Aug 19, 2024

Change Summary

fix typos in dell-vep* and xpcng build-flavors

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@bk2zsto bk2zsto requested a review from a team as a code owner August 19, 2024 20:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Aug 19, 2024
@bk2zsto
Copy link
Contributor Author

bk2zsto commented Aug 19, 2024

subject line format

@bk2zsto bk2zsto changed the title singular image_format in flavor files build: T6666: singular image_format in flavor files Aug 19, 2024
@sever-sever
Copy link
Member

sever-sever commented Aug 20, 2024 •
edited
Loading

The commit message is still incorrect
pr

@bk2zsto bk2zsto force-pushed the image_format_singular branch from 96f5426 to 16a4c4d Compare August 20, 2024 13:57
@c-po c-po enabled auto-merge August 20, 2024 17:34
@c-po
Copy link
Member

c-po commented Aug 20, 2024

@Mergifyio backport sagitta circinus

@mergify Mergify
Copy link

mergify bot commented Aug 20, 2024 •
edited
Loading

backport sagitta circinus

✅ Backports have been created

@c-po c-po merged commit c5c6a13 into vyos:current Aug 22, 2024
9 checks passed
This was referenced Aug 22, 2024
Merged
Merged
dmbaturin added a commit that referenced this pull request Aug 24, 2024
@dmbaturin
Merge pull request #743 from vyos/mergify/bp/circinus/pr-738
d75f683 
build: T6666: singular image_format in flavor files (backport #738)
c-po added a commit that referenced this pull request Aug 24, 2024
@c-po
Merge pull request #742 from vyos/mergify/bp/sagitta/pr-738
8bfc5b1 
build: T6666: singular image_format in flavor files (backport #738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@bk2zsto bk2zsto

Labels
backport current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bk2zsto @sever-sever @c-po @dmbaturin