Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: T4919: Fix QEMU TPM test #765

Merged
merged 3 commits into from
Sep 17, 2024
Merged

test: T4919: Fix QEMU TPM test #765

merged 3 commits into from
Sep 17, 2024

Conversation

sarthurdev
Copy link
Member

@sarthurdev sarthurdev commented Sep 17, 2024 •
edited
Loading

Change Summary

Update TPM test for changes made to test script

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

tpm

Proposed changes

Changes to test script was not directly compatible with the TPM test and needed updating to handle reboot instead of VM shutdown. TPM is now present as needed in initial installer VM.

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@sarthurdev sarthurdev requested a review from a team as a code owner September 17, 2024 09:40
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Sep 17, 2024
@sarthurdev sarthurdev merged commit 2a53f21 into vyos:current Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@sarthurdev sarthurdev

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarthurdev @jestabro @sever-sever