Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6738: add build_type field to version data instead of the very limited and unused lts_build #773

Merged
merged 1 commit into from
Sep 30, 2024
Merged

build: T6738: add build_type field to version data instead of the very limited and unused lts_build #773

merged 1 commit into from
Sep 30, 2024

Conversation

dmbaturin
Copy link
Member

Change Summary

Remove lts_build and add build_type that can have potentially abitrary values (in practice it will be development/stream/lts.).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): internal change.

Component(s) name

Build scripts.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@dmbaturin
build: T6738: add build_type field to version data
e41d2f1 
instead of the very limited and unused lts_build
@dmbaturin dmbaturin requested a review from a team as a code owner September 25, 2024 10:58
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Sep 25, 2024
@c-po c-po merged commit 47de7d4 into vyos:current Sep 30, 2024
10 checks passed
@dmbaturin
Copy link
Member Author

@Mergifyio backport circinus

@mergify Mergify
Copy link

mergify bot commented Sep 30, 2024 •
edited
Loading

backport circinus

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 30, 2024
Merged
11 tasks
c-po added a commit that referenced this pull request Sep 30, 2024
@c-po
Merge pull request #775 from vyos/mergify/bp/circinus/pr-773
5853612 
build: T6738: add build_type field to version data instead of the very limited and unused lts_build (backport #773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@jestabro jestabro jestabro approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@dmbaturin dmbaturin

Labels
backport current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmbaturin @jestabro @c-po