Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: T6923: use the Debian mirror for security updates if it's specified explicitly #849

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

dmbaturin
Copy link
Member

Change Summary

If the user runs sudo ./build-vyos-image --debian-mirror $URL, use $URL for all Debian mirror URLs in lb config.

It's still possible to specify different mirrors for "Debian mirror" (--debian-mirror), "Debian security mirror" (--debian-security-mirror), and mirror for pbuilder (--pbuilder-debian-mirror) if needed.

But in most cases if someone specifies a custom mirror, they usually want it for all roles and trying to make them specify everything explicitly that live-build allows to specify explicitly is redundant.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Build scripts.

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

…ified explicitly

but the security mirror is not
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Nov 29, 2024
@c-po c-po enabled auto-merge November 30, 2024 07:50
@c-po c-po merged commit 5bccbeb into vyos:current Nov 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

3 participants