Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6922: add an option to specify bootloaders for the image #850

Merged
merged 1 commit into from
Nov 30, 2024
Merged

build: T6922: add an option to specify bootloaders for the image #850

merged 1 commit into from
Nov 30, 2024

Conversation

dmbaturin
Copy link
Member

Change Summary

Add --bootloaders option to override the flavor default or system default in a one-off build job.

Note that it's already possible to specify bootloaders in flavor files, which is the preferred way for permanent flavor definitions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Build scripts.

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@dmbaturin dmbaturin requested a review from a team as a code owner November 29, 2024 17:06
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Nov 29, 2024
@c-po c-po merged commit 5833ce1 into vyos:current Nov 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestabro jestabro jestabro approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever was automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 was automatically assigned from vyos/reviewers

Assignees

@dmbaturin dmbaturin

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmbaturin @jestabro @c-po