Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6960: package-build: Disable unnecessary builds for amazon-cloudwatch-agent package #864

Merged
merged 1 commit into from
Dec 19, 2024
Merged

T6960: package-build: Disable unnecessary builds for amazon-cloudwatch-agent package #864

merged 1 commit into from
Dec 19, 2024

Conversation

MattKobayashi
Copy link
Contributor

@MattKobayashi MattKobayashi commented Dec 18, 2024 •
edited
Loading

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6960

Component(s) name

package-build (amazon-cloudwatch-agent)

Proposed changes

This change simply bypasses the build steps for the Darwin and Windows agents.

How to test

(using the modified package.toml)

git clone https://github.com/vyos/vyos-build
cd vyos-build/scripts/package-build/amazon-cloudwatch-agent
./build.py

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@MattKobayashi MattKobayashi requested a review from a team as a code owner December 18, 2024 22:18
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Dec 18, 2024
@dmbaturin dmbaturin merged commit f7ec15e into vyos:current Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@MattKobayashi MattKobayashi

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattKobayashi @dmbaturin @sever-sever