Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6674: move patches to "package/<package_name>" subfolder #868

Merged
merged 2 commits into from
Dec 22, 2024
Merged

T6674: move patches to "package/<package_name>" subfolder #868

merged 2 commits into from
Dec 22, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 22, 2024

Change Summary

This prevents the accidental applying of a patch to multiple source directories defined in package.toml.

Example FRR:
Package consits of build instructions for libyang, rtrlib and frr itself. Previously patches in frr/patches folder got applied to libyang, rtrlib and frr which made no sense and could also fail a build.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner December 22, 2024 11:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@github-actions github-actions bot added the current VyOS rolling release label Dec 22, 2024
c-po added 2 commits December 22, 2024 16:22
@c-po
T6674: use common .gitignore file for Package build artifacts/sources
6aa3bb5
@c-po
T6674: move patches to "package/<package_name>" subfolder
53ceb24 
This prevents the accidental applying of a patch to multiple source directories
defined in package.toml.

Example FRR:
Package consits of build instructions for libyang, rtrlib and frr itself.
Previously patches in frr/patches folder got applied to libyang, rtrlib and frr
which made no sense and could also fail a build.
@sever-sever sever-sever merged commit 3b377bd into vyos:current Dec 22, 2024
8 checks passed
@c-po c-po deleted the package-build branch December 22, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-po @sever-sever