T6404: add constraintGroup element to reference tree

[jestabro]

Change Summary

The constraintGroup element was missed when defining the reference tree, as it has not yet had a use case. However, in the context of https://vyos.dev/T3493, it was suggested to use the following construction quoted below (only in Sagitta); note that a partial solution is already present, and may be considered sufficient.

For future use of a constraintGroup, this PR should be merged for 1.5, and the Dockerfile updated.

NOTE: it is up to @c-po whether this should be backported to allow extending T3493 with the patch below: if so, we need to make sure that the Dockerfile has been updated with commit ref for vyos1x-config AND that libvyosconfig and vyos-1x are rebuilt with that container before 1.4.0-GA.

Tested with the patch below, all smoketests pass, notably, test_service_dhcpv6-server.py.

diff --git a/interface-definitions/service_dhcpv6-server.xml.in b/interface-definitions/service_dhcpv6-server.xml.in
index effba3884..589eb709c 100644
--- a/interface-definitions/service_dhcpv6-server.xml.in
+++ b/interface-definitions/service_dhcpv6-server.xml.in
@@ -228,10 +228,11 @@
                             <format>ipv6</format>
                             <description>IPv6 address used in prefix delegation</description>
                           </valueHelp>
-                          <constraint>
+                          <constraintGroup>
+                            <validator name="ipv6-address"/>
                             <!-- IPv6 address used MUST end with :: -->
                             <regex>([a-fA-F0-9]{1,4}:)+:</regex>
-                          </constraint>
+                          </constraintGroup>
                         </properties>
                         <children>
                           <leafNode name="prefix-length">
@@ -254,10 +255,11 @@
                                 <format>ipv6</format>
                                 <description>IPv6 address used in prefix delegation</description>
                               </valueHelp>
-                              <constraint>
+                              <constraintGroup>
+                                <validator name="ipv6-address"/>
                                 <!-- IPv6 address used MUST end with :: -->
                                 <regex>([a-fA-F0-9]{1,4}:)+:</regex>
-                              </constraint>
+                              </constraintGroup>
                             </properties>
                           </leafNode>
                         </children>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Other (please describe):

Related Task(s)

Related PR(s)

Proposed changes

How to test

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[c-po]

@Mergifyio backport sagitta

[mergify]

backport sagitta

✅ Backports have been created

• #28 T6404: add constraintGroup element to reference tree (backport #27) has been created for branch sagitta