Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a warning when exceeding code size limit (EIP-170) #1850

Closed
iamdefinitelyahuman opened this issue Feb 9, 2020 · 3 comments
Closed
Labels
Easy Pickings Used to denote issues that should be easy to implement enhancement

Comments

@iamdefinitelyahuman
Copy link
Contributor

What's your issue about?

The compiler should raise a warning when size of the generated runtime bytecode is >24577 bytes (EIP-170).

Because other chains may have different / no limits, we should not raise an exception. But I think for the majority of users, a warning will save some debugging headaches.

@fubuloubu fubuloubu added Easy Pickings Used to denote issues that should be easy to implement enhancement labels Feb 9, 2020
@fubuloubu
Copy link
Member

Just to clarify, is it the deployment bytecode or the runtime bytecode that's affected by this size?

I believe it's the runtime, but should be sure of that. Error message should probably give some of this context too e.g. constructor doesn't count towards codesize

@iamdefinitelyahuman
Copy link
Contributor Author

Yes, 100% it's based on runtime bytecode.

@fubuloubu
Copy link
Member

close in favor of #2150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Pickings Used to denote issues that should be easy to implement enhancement
Projects
None yet
Development

No branches or pull requests

2 participants