-
-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise warning when EIP-170 contract size limit is exceeded #2208
raise warning when EIP-170 contract size limit is exceeded #2208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2208 +/- ##
==========================================
+ Coverage 85.31% 85.36% +0.04%
==========================================
Files 83 84 +1
Lines 8525 8533 +8
Branches 2063 2064 +1
==========================================
+ Hits 7273 7284 +11
+ Misses 745 743 -2
+ Partials 507 506 -1
Continue to review full report at Codecov.
|
1e3a5ec
to
bef27bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor nits
bef27bd
to
b178353
Compare
@lr4d thanks for seeing that! |
What I did
Fixes #2150
Still to-do according to #2150 (comment):
I'm not too familiar with the internals yet, so would appreciate suggestions on the suggestions to be provided.
How I did it
How to verify it
Description for the changelog
Cute Animal Picture