create_with_code_of() does not execute __init__

[haydenadams]

• vyper Version: 0.0.4
• pyethereum Version: 2.3.1
• OS: macOS
• Python Version: 3.6.4

What's your issue about?

My post might be unnecessary if #649 is going to be the standard factory pattern.

I'm working on a factory contract that uses create_with_code_of() to launch exchange contracts.

Ideally I want the contract that is launched to know the address of the factory. Since create_with_code_of() does not support passing arguments, I tried setting it in the constructor of the exchange:

unfortunately, this does not work:

How can it be fixed?

Allow contracts created using create_with_code_of() to recognize msg.sender in the constructor.

Or not if #649 is implemented

Or I'm missing something/there is a better factory pattern I should be using that allows passing parameters?

Cute Animal Picture

[jacqueswww]

@haydenadams I will have to dig deeper exactly what's wrong. Could it be that the init code isn't ever executed?

[haydenadams]

@jacqueswww Tried setting something else in init and it returned 0. As far as I can tell, init is never executed in create_with_code_of()

[jacqueswww]

That's what I suspected, basically the init code isn't part of the runtime code on chain. We'll have to figure out a new function or extension of the existing function that allows you to scrape the init code.

[jacqueswww]

In the meantime you can build a fake init function with a boolean that can only be called once :-P

[haydenadams]

Makes sense, thanks! Already implemented that as a temporary solution.

[haydenadams]

In my current solution, the factory does a raw_call() on the new contract immediately after calling create_with_code_of().

Factory

Exchange

Since the contract creation and raw_call are done in the same function, and setup() can only be called once, it essentially functions as a constructor.

[haydenadams]

@jacqueswww

That's what I suspected, basically the init code isn't part of the runtime code on chain. We'll have to figure out a new function or extension of the existing function that allows you to scrape the init code.

btw b/c of this, Unisocks classic was able to verify on etherscan with this code:
https://etherscan.io/address/0xf7a5a8a95491ec170738434963b649671b563b88#code

despite their init function being different.

[fubuloubu]

Unisocks classic

🤣🤣🤣

[haydenadams]

Nice!