feat: create_from_factory and create_copy_of #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 49 alerts when merging 60323b6 into 90e3d20 - view on LGTM.com new alerts:
|
create_copy_of is required since there isn't really an ergonomic way to get a bytestring with the bytecode of a contract (and even if there were, it would over-allocate memory)
charles-cooper
force-pushed
the
create_zoo
branch
2 times, most recently
from
f2972d0 to
c9ba77b
Compare
create_copy_of and create_with_code_of. delete raw create() function
charles-cooper
force-pushed
the
create_zoo
branch
from
c9ba77b to
34b3112
Compare
add varargs flag to builtins fix abi encoder memory allocator issue
charles-cooper
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2895 +/- ##
==========================================
- Coverage 88.05% 87.53% -0.53%
==========================================
Files 95 95
Lines 10442 10575 +133
Branches 2512 2532 +20
==========================================
+ Hits 9195 9257 +62
- Misses 790 848 +58
- Partials 457 470 +13
Continue to review full report at Codecov.
|
tserg
reviewed
Jun 10, 2022
charles-cooper
force-pushed
the
create_zoo
branch
from
8faeed6 to
d31d593
Compare
charles-cooper
changed the title
Merged
tserg
reviewed
Jun 14, 2022
fubuloubu
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
add
create_from_factoryandcreate_copy_ofbuiltinscreate_copy_ofcopies the runtime code at the given addresscreate_from_factorytreats the code at given address as initcode, and tacks on the varargs so that the constructor interprets them as constructor arguments.create_forwarder_totocreate_minimal_proxy_to(still allows the old name as a deprecated alias)fixes #1362, fixes #773, fixes #2893, fixes #2890, closes #2883
also added
_has_varargsflag to SimpleBuiltinFunction. builtins now need a bit of refactoring, but saving that for a follow-up PR.open question: should we revert if extcodesize of the target contract is 0? thinking yesreverts if extcodesize of target contract is 0.How I did it
some mucking around with assembly
How to verify it
check tests
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture