External contract call interfaces #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacqueswww
changed the title
|
This breaking change should derive from a VIP discussion so it's more obvious where it stems from |
|
We discussed these on call, 28th January IIRC |
|
Issues, or it didn't happen 😛 |
|
I'll amend the original VIP. |
|
@fubuloubu I see I did actually note phase 2 on the VIP: #885 (comment) will ammend #885 |
|
I still don't think the specific change |
|
@fubuloubu 👍 #1251 knock yourself out. |
jacqueswww
force-pushed
the
1214_external_contract_calls
branch
from
5ad30d9 to
c9c37b7
Compare
jacqueswww
force-pushed
the
1214_external_contract_calls
branch
from
c9c37b7 to
15ffde2
Compare
fubuloubu
reviewed
Feb 19, 2019
|
Not really necessary, it's only parsing that needs to be checked ;) |
|
If both of those keywords did nothing in the compiler, it would still parse. Ergo, it should have a short test |
jacqueswww
force-pushed
the
1214_external_contract_calls
branch
from
3770c56 to
d82a0d3
Compare
…vyper into 1214_external_contract_calls
fubuloubu
reviewed
Feb 25, 2019
tests/examples/safe_remote_purchase/test_safe_remote_purchase.py
Outdated
Show resolved
Hide resolved
fubuloubu
reviewed
Feb 26, 2019
|
Will fix it thx ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #1214 #885 (phase2) to allow external interfaces to be used to make calls.
Fixes #1215.
How I did it
How to verify it
Description for the changelog
Cute Animal Picture