Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix source code annotation for sqrt #2691

Merged
merged 6 commits into from
Mar 28, 2022

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 5, 2022

the parse_body call in generate_inline_function attaches incorrect
position info into the generated code.

What I did

fix #2676

How I did it

How to verify it

check that a contract with sqrt in it compiles with brownie

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

the `parse_body` call in `generate_inline_function` attaches incorrect
position info into the generated code.
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #2691 (e288332) into master (ce6c5d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2691   +/-   ##
=======================================
  Coverage   87.26%   87.27%           
=======================================
  Files          93       93           
  Lines        9902     9907    +5     
  Branches     2470     2471    +1     
=======================================
+ Hits         8641     8646    +5     
  Misses        777      777           
  Partials      484      484           
Impacted Files Coverage Δ
vyper/builtin_functions/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6c5d7...e288332. Read the comment docs.

@charles-cooper charles-cooper requested a review from fubuloubu March 5, 2022 18:22
@charles-cooper charles-cooper mentioned this pull request Mar 24, 2022
3 tasks
@charles-cooper charles-cooper merged commit 81f01c0 into vyperlang:master Mar 28, 2022
@charles-cooper charles-cooper deleted the fix/sqrt_code branch March 28, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vyper + Brownie (sqrt error)
3 participants