Skip to content

Commit

Permalink
[Test Fix]Fix test nit, there is no public is_live method provided. (m…
Browse files Browse the repository at this point in the history
…icrosoft#3298)

# Description

Fix test nit, there is no public is_live method provided.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
  • Loading branch information
crazygao authored May 17, 2024
1 parent 1f3d495 commit 2c66be5
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from promptflow._utils.multimedia_utils import OpenaiVisionMultimediaProcessor
from promptflow.core._serving.constants import FEEDBACK_TRACE_FIELD_NAME
from promptflow.core._serving.utils import load_feedback_swagger
from promptflow.recording.record_mode import is_live
from promptflow.tracing._operation_context import OperationContext


Expand Down Expand Up @@ -506,7 +505,7 @@ def test_prompty_serving_api(prompty_serving_client):

@pytest.mark.usefixtures("recording_injection", "setup_local_connection")
@pytest.mark.e2etest
@pytest.mark.skipif(not is_live(), reason="llm request involved but no recording found")
@pytest.mark.skipif(not pytest.is_live, reason="llm request involved but no recording found")
def test_prompty_serving_api_live(prompty_serving_client):
response = prompty_serving_client.post(
"/score", data=json.dumps({"firstName": "first", "lastName": "last", "question": "hello"})
Expand Down

0 comments on commit 2c66be5

Please sign in to comment.