Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtx: skybox looks way duller than in gl renderer #230

Closed
w23 opened this issue Nov 25, 2021 · 3 comments
Closed

rtx: skybox looks way duller than in gl renderer #230

w23 opened this issue Nov 25, 2021 · 3 comments
Labels
question Further information is requested ray tracing visual bug Visual glitches, something looks incorrectly

Comments

@w23
Copy link
Owner

w23 commented Nov 25, 2021

It's almost as if gamma is slightly incorrect?
Tried: _SRGB instead of _UNORM, looks relatively correct (modulo aces tonemap).

Not clear why would skybox texture only require _SRGB. I think all of the textures need to be _SRGB, but then they look completely wrong.

@w23 w23 added question Further information is requested ray tracing visual bug Visual glitches, something looks incorrectly labels Nov 25, 2021
w23 added a commit that referenced this issue Nov 25, 2021
@0x4E69676874466F78
Copy link
Collaborator

0x4E69676874466F78 commented Dec 17, 2021

Подозреваю что это из-за того что небо это additive и тогда #267 (comment) (1 пункт).
Как раз совпадает

payload.emissive = pow(texture(skybox, gl_WorldRayDirectionEXT).rgb, vec3(2.2)); // Why?! See #230
с #267 (comment) (pow(tex_color.rgb, vec3(2.)); )
Да и кто у нас payload.emissive? additive только.

Заодно починить: #284

@0x4E69676874466F78
Copy link
Collaborator

Так что после того как починишь additive надо будет выпилить этот pow для skybox.

@0x4E69676874466F78
Copy link
Collaborator

Это можно закрыть. Была проблема с гаммой. Детали здесь: #321

@w23 w23 closed this as completed Jun 4, 2022
@0x4E69676874466F78 0x4E69676874466F78 moved this to ✅ Done in HLRT Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested ray tracing visual bug Visual glitches, something looks incorrectly
Projects
Status: Done
Development

No branches or pull requests

2 participants