Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vk_toggle_pbr_textures cvar for traditional render #711

Closed
0x4E69676874466F78 opened this issue Dec 17, 2023 · 1 comment · Fixed by #712
Closed

Add vk_toggle_pbr_textures cvar for traditional render #711

0x4E69676874466F78 opened this issue Dec 17, 2023 · 1 comment · Fixed by #712
Labels
trad Only affects traditional rendering

Comments

@0x4E69676874466F78
Copy link
Collaborator

Чтобы на растеризации можно было включить basecolor_map текстуру, чтобы те у кого пока нет лучей могли хотя бы примерно понять как выглядит.
@0x4E69676874466F78 0x4E69676874466F78 added the trad Only affects traditional rendering label Dec 17, 2023
@0x4E69676874466F78 0x4E69676874466F78 moved this to 🗒 Next in HLRT Dec 17, 2023
@0x4E69676874466F78 0x4E69676874466F78 changed the title Add vk_toggle_pbr_textures for traditional render Add vk_toggle_pbr_textures cvar for traditional render Dec 17, 2023
w23 added a commit that referenced this issue Dec 18, 2023
@w23
vk: trad: allow rendering with replaced PBR textures
3260469 
Use `vk_use_material_textures` cvar to show new PBR material textures
for traditional rendering.
Note that they're often sampled in an incorrect colorspace, so they look
different from RT.

Fixes #711
@w23 w23 mentioned this issue Dec 18, 2023
Merged
@w23 w23 moved this from 🗒 Next to 👀 In review in HLRT Dec 18, 2023
@w23
Copy link
Owner

w23 commented Dec 18, 2023

Рисует, но в неправильном цветовом пространстве (sRGB текстуры семплит как UNORM (linear)). Это можно починить, но с трудом -- надо отдельно сохранять sRGB дескрипторы, сейчас их попросту нет, т.к. семплинг в лучах делается иначе -- через bindless.

@w23 w23 closed this as completed in #712 Dec 18, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in HLRT Dec 18, 2023
w23 added a commit that referenced this issue Dec 18, 2023
@w23
vk: trad: allow rendering with replaced PBR textures
a0b36a4 
Use `vk_use_material_textures` cvar to show new PBR material textures
for traditional rendering.
Note that they're often sampled in an incorrect colorspace, so they look
different from RT.

Fixes #711
@w23 w23 mentioned this issue Dec 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
trad Only affects traditional rendering
Projects
HLRT
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vk: trad: allow rendering with replaced PBR textures w23/xash3d-fwgs
2 participants
@w23 @0x4E69676874466F78