Add Ladle stories #500
Merged
Add Ladle stories #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds storybook documentation for the RotatingLoader component to improve component visibility and testing capabilities in the UI development workflow.
The error boundary component now supports a compact display mode for use in stories and other confined spaces, providing a more condensed error message presentation.
Implement comprehensive test scenarios for the hamburger menu component, including default state, X state, interactive toggle, and background variants to ensure consistent behavior across different contexts.
This addition provides comprehensive storybook examples for the NavigationLink component, showcasing various states and layouts for better development and testing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
===========================================
- Coverage 100.00% 99.38% -0.62%
===========================================
Files 30 32 +2
Lines 313 324 +11
Branches 79 81 +2
===========================================
+ Hits 313 322 +9
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
Created comprehensive test cases for footer component including default, narrow, and wide viewport scenarios to ensure responsive behavior and proper rendering
This commit removes an unnecessary import of the Story component from @ladle/react which was not being used in the Footer stories file, keeping the codebase clean.
The ErrorFallbackWrapper component has been extracted to improve code organization and reusability. This component now handles the presentation of error states with compact mode support.
Streamlines ErrorBoundary story examples by removing unnecessary wrappers and standardizing component styling. Also imports global CSS for consistent theming.
The stories for PageHeader component have been restructured to provide more comprehensive examples including responsive layouts, icons, and various text lengths. Import statements have been simplified and globals.css has been included.
This commit removes an unused import statement from the ErrorBoundary story file to maintain code cleanliness. The Story type from @ladle/react was imported but not used in the component.
Extract ErrorFallbackWrapper into separate component and improve error handling code organization for better maintainability and type safety in ErrorBoundary component BREAKING CHANGE: ErrorFallbackWrapper is now a separate component file
Update ErrorBoundary component to use proper React ErrorInfo type instead of inline object type for better type safety and maintainability
Expanded test suite with comprehensive checks for orientation, border styles, and tab panel attributes. Added type safety with TypeScript interface and improved motion component mocking for better test reliability.
Streamline test cases by removing CV-specific mock data and focusing on core tab functionality. Add error boundary testing and improve ARIA validation coverage while reducing redundant assertions.
Updates the code formatting in Tabs test file to be more consistent and readable, applying proper indentation for JSX components and fixing comma placement in array objects.
Enhance readability and consistency by adding parentheses to arrow function parameters and removing unreachable code in the ErrorBoundary stories file.
The PageHeader stories file has been reformatted to maintain consistent code style throughout the codebase. This includes standardizing quotes, removing unnecessary line breaks, and improving overall readability.
Extracted FallbackComponent to a separate const to improve code organization and readability. This avoids nested component definitions and makes the error handling logic more maintainable.
Improves code organization by moving the error fallback component into its own file and simplifies the main ErrorBoundary component structure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.