Rename Dilithium to ML-DSA #1

wip-abramson · 2024-05-14T17:43:36Z

I have removed all references to dilithium. Using ML-DSA-44 or experimental-mldsa-2024 where appropriate.

I am not sure what this means for the current examples, I assume they would have to change.

I also attempted to add a reference to the FIPS paper, which I think specifies this ML-DSA algorithm. But I definitely didn't do this correctly.

It is a start :)

Preview | Diff

andrea-dintino

We used "cryptosuite": "experimental-mldsa44-2024" in the VC. I guess it's desirable to specify which flavor of the algo we're using, as later we may implement different flavors, with format differences... but I'm happy both ways. My comment applies to the whole html, not just related to my 2 comments.

andrea-dintino · 2024-05-27T14:56:09Z

index.html

@@ -457,20 +465,20 @@ <h4>DataIntegrityProof</h4>
          </p>
          <p>
 The `cryptosuite` property of the proof MUST be
-`experimental-quantum-safe-dilithium-2024`.
+`experimental-ml-dsa-2024`.


we used "experimental-mldsa44-2024" as ml-dsa-44 is the only algo we implemented so far

andrea-dintino · 2024-05-27T14:56:23Z

index.html

@@ -480,7 +488,7 @@ <h4>DataIntegrityProof</h4>
  "myWebsite": "https://hello.world.example/",
  "proof": {
    "type": "DataIntegrityProof",
-    "cryptosuite": "experimental-quantum-safe-dilithium-2024",
+    "cryptosuite": "experimental-mldsa-2024",


Same as above

msporny · 2024-05-27T16:04:22Z

index.html

-[[VC-DATA-INTEGRITY]] produced using Dilithium cryptographic key material
-that is compliant with <span class="issue">cite Dilithium spec</span>.
+[[VC-DATA-INTEGRITY]] produced using ML-DSA-44 cryptographic key material
+that is compliant with <span class="issue">cite ML-DSA spec - I belive this is FIPS-204</span>.


Yes, it's FIPS-204.

Suggested change

that is compliant with <span class="issue">cite ML-DSA spec - I belive this is FIPS-204</span>.

that is compliant with the [[[FIPS-204]]].

msporny · 2024-05-27T16:05:36Z

index.html

-expression of a Dilithium public key.
-<span class="issue">Specify acceptable Dilithium key sizes</span>
+expression of a ML-DSA public key.
+<span class="issue">Specify acceptable ML-DSA key sizes</span>


ML-DSA-44 public key size is 1312 bytes, private key size is 2528 bytes.

Great, these values are already there. Removing this issue

msporny · 2024-05-27T16:07:06Z

index.html

          </p>

          <p>
-The Multikey encoding of a Dilithium public key MUST start with the two-byte
+The Multikey encoding of a ML-DSA public key MUST start with the two-byte
 prefix `0x8724` (the varint expression of `0x1207`) followed by the 1312-byte


Reminder that we /really/ need to register these values here: https://github.com/multiformats/multicodec/blob/master/table.csv#L168

I raised an issue to track this: #2

msporny · 2024-05-27T16:07:45Z

index.html

 signature produced according to using the algorithms specified in section
 [[[#algorithms]]], encoded according
-to ??? encoded using the base-64-url-nopad header and
+to <span class="issue">What is the encoding?</span>??? encoded using the base-64-url-nopad header and


Encoding is whatever is in FIPS-204.

Encoding is whatever is in FIPS-204.

I checked FIPS-204 at page 24, and it seems that no encoding is defined. We're using liboqs which takes binaries as input/output.

We're currently using base64 for keys and sigs... should we stick to that?

My understanding is we would use the pkEncode function to repsent the keys as bytes following FIPS-204 then encode those bytes in some manner.

I think we should use multibase as thats what the other data integrity specs use. Whether base58-btc or base64 I don't know, I think I prefer base58

I guess it is already using multibase actually

msporny · 2024-05-27T16:08:20Z

index.html

@@ -898,7 +906,7 @@ <h4>Proof Serialization (experimental-dilithium-quantum-safe-2024)</h4>
 |options|.|verificationMethod| value.
            </li>
            <li>
-Let |proofBytes| be the result of applying the Dilithium-2
+Let |proofBytes| be the result of applying the ML_DSA_44
 Signature Algorithm [???REF???], with |hashData| as the data


Ref is to FIPS-204.

I think I included the FIPS in the references, but I couldnt figure out how to ref it properly. Or maybe I didn't include it in the list right. Taking another look ...

msporny

Approved with a few nits that would be nice to resolve in this PR. If not, we can do it later.

wip-abramson · 2024-05-29T14:33:51Z

I will try address the comments :)

index.html

davidlehn · 2024-05-29T18:38:48Z

index.html

 private key).
          </p>
          <p>
-The encoding of a Dilithium=2 secret key MUST start with the two-byte prefix
+The encoding of a <span class="issue">What should this be now we have moved to ML-DSA</span>ML-DSA=44 secret key MUST start with the two-byte prefix


Should = be a -?

Co-authored-by: David I. Lehn <[email protected]>

wip-abramson · 2024-06-04T17:14:12Z

Okay, I think this is good to go. Can I merge?

andrea-dintino · 2024-06-05T07:30:29Z

Okay, I think this is good to go. Can I merge?

Yes from me :-)

wip-abramson added 2 commits May 14, 2024 11:32

update dilithium to ml-dsa

9975305

attempt to add FIPS-204 reference

607011e

wip-abramson requested a review from msporny as a code owner May 14, 2024 17:43

andrea-dintino reviewed May 27, 2024

View reviewed changes

msporny reviewed May 27, 2024

View reviewed changes

msporny approved these changes May 27, 2024

View reviewed changes

wip-abramson added 2 commits May 29, 2024 09:41

update to experimental-mldsa44-2024

10ada4e

fix refs to FIPS

70c8a32

davidlehn reviewed May 29, 2024

View reviewed changes

andrea-dintino approved these changes May 30, 2024

View reviewed changes

wip-abramson and others added 3 commits May 30, 2024 11:31

Update index.html

30aebb9

Co-authored-by: David I. Lehn <[email protected]>

Update index.html

f08a022

Co-authored-by: David I. Lehn <[email protected]>

minor fix

1f4ce06

wip-abramson merged commit 9e0d957 into w3c-ccg:main Jun 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename Dilithium to ML-DSA #1

Rename Dilithium to ML-DSA #1

wip-abramson commented May 14, 2024 •

edited by pr-preview bot

Loading

andrea-dintino left a comment •

edited

Loading

andrea-dintino May 27, 2024

andrea-dintino May 27, 2024

msporny May 27, 2024

msporny May 27, 2024

wip-abramson May 29, 2024

msporny May 27, 2024

wip-abramson May 29, 2024 •

edited

Loading

msporny May 27, 2024

andrea-dintino May 30, 2024 •

edited

Loading

wip-abramson May 30, 2024

wip-abramson May 30, 2024

msporny May 27, 2024

wip-abramson May 29, 2024

msporny left a comment

wip-abramson commented May 29, 2024

davidlehn May 29, 2024

wip-abramson commented Jun 4, 2024

andrea-dintino commented Jun 5, 2024

	that is compliant with <span class="issue">cite ML-DSA spec - I belive this is FIPS-204</span>.
	that is compliant with the [[[FIPS-204]]].

Rename Dilithium to ML-DSA #1

Rename Dilithium to ML-DSA #1

Conversation

wip-abramson commented May 14, 2024 • edited by pr-preview bot Loading

andrea-dintino left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wip-abramson May 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrea-dintino May 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msporny left a comment

Choose a reason for hiding this comment

wip-abramson commented May 29, 2024

Choose a reason for hiding this comment

wip-abramson commented Jun 4, 2024

andrea-dintino commented Jun 5, 2024

wip-abramson commented May 14, 2024 •

edited by pr-preview bot

Loading

andrea-dintino left a comment •

edited

Loading

wip-abramson May 29, 2024 •

edited

Loading

andrea-dintino May 30, 2024 •

edited

Loading