Disallow proxies during key conversion #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PR uploaded |
inexorabletash
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 21, 2019
Arrays of keys are valid keys, but implementations don't allow proxies of arrays to be keys. Add a test, corresponding to pending spec PR: Bug: w3c/IndexedDB#309 PR: w3c/IndexedDB#311
|
@asutherland - please take a look? |
asutherland
approved these changes
Nov 22, 2019
|
Verified that Safari 13 already exhibits this behavior, so I think we're good. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 29, 2019
… valid keys, a=testonly Automatic update from web-platform-tests Indexed DB: Verify array proxies are not valid keys (#20352) Arrays of keys are valid keys, but implementations don't allow proxies of arrays to be keys. Add a test, corresponding to pending spec PR: Bug: w3c/IndexedDB#309 PR: w3c/IndexedDB#311 -- wpt-commits: c65519066cf95e902607cce03a9057b859a50242 wpt-pr: 20352
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 29, 2019
… valid keys, a=testonly Automatic update from web-platform-tests Indexed DB: Verify array proxies are not valid keys (#20352) Arrays of keys are valid keys, but implementations don't allow proxies of arrays to be keys. Add a test, corresponding to pending spec PR: Bug: w3c/IndexedDB#309 PR: w3c/IndexedDB#311 -- wpt-commits: c65519066cf95e902607cce03a9057b859a50242 wpt-pr: 20352
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2019
… valid keys, a=testonly Automatic update from web-platform-tests Indexed DB: Verify array proxies are not valid keys (#20352) Arrays of keys are valid keys, but implementations don't allow proxies of arrays to be keys. Add a test, corresponding to pending spec PR: Bug: w3c/IndexedDB#309 PR: w3c/IndexedDB#311 -- wpt-commits: c65519066cf95e902607cce03a9057b859a50242 wpt-pr: 20352 UltraBlame original commit: a1415e648ad42f37c59425a107c33728af78cfb1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2019
… valid keys, a=testonly Automatic update from web-platform-tests Indexed DB: Verify array proxies are not valid keys (#20352) Arrays of keys are valid keys, but implementations don't allow proxies of arrays to be keys. Add a test, corresponding to pending spec PR: Bug: w3c/IndexedDB#309 PR: w3c/IndexedDB#311 -- wpt-commits: c65519066cf95e902607cce03a9057b859a50242 wpt-pr: 20352 UltraBlame original commit: a1415e648ad42f37c59425a107c33728af78cfb1
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2019
… valid keys, a=testonly Automatic update from web-platform-tests Indexed DB: Verify array proxies are not valid keys (#20352) Arrays of keys are valid keys, but implementations don't allow proxies of arrays to be keys. Add a test, corresponding to pending spec PR: Bug: w3c/IndexedDB#309 PR: w3c/IndexedDB#311 -- wpt-commits: c65519066cf95e902607cce03a9057b859a50242 wpt-pr: 20352 UltraBlame original commit: a1415e648ad42f37c59425a107c33728af78cfb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Gecko and Chromium disallow using proxies when specifying keys, e.g.:
Enshrining this seems like a good idea.
Closes #309
The following tasks have been completed:
Implementation commitment:
Preview | Diff