Fix the timing of running the IntersectionObserver algorithm #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the TAG review, IntersectionObserver should run its algorithm *after* requestAnimationFrame callbacks, not before.
|
@szager-chromium, thanks! Is there a web platform test to verify the new behavior? |
|
@marcoscaceres All of the existing WPT tests already expect that behavior; the previous spec language was just wrong, and I'm pretty sure all of the browsers just ignored it and did the Right Thing. |
|
Excellent! thank you for confirming. |
dbaron
added a commit
to dbaron/IntersectionObserver
that referenced
this pull request
Dec 18, 2018
…bserver. Since the HTML spec has been updated to reference IntersectionObserver, this change stops monkeypatching the HTML spec to make a change that already exists in it. (To some degree this is followup to w3c#331.) Instead, it points out where the integration exists in the HTML spec. This avoids having two normative definitions of the same thing that slightly disagree with each other. It's worth noting that the monkeypatch is slightly different from what's in HTML; where this spec's monkeypatch said "for each IntersectionObserver whose root is in the DOMtree of that Document", the HTML spec says "for that Document, passing in now as the timestamp". Given the text in #run-the-update-intersection-observations-steps, the text in HTML is correct regarding both differences, since the algorithm both (a) expects a time and (b) builds a list of all roots in the Document. This also marks the definition that HTML uses as <dfn export>; this really only serves to silence a bikeshed warning (which appears when removing the monkeypatch) since the HTML spec isn't written using bikeshed; however, it also means that the reference HTML makes could be done in a spec that used bikeshed, so it deserves to be exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the TAG review, IntersectionObserver should run its
algorithm after requestAnimationFrame callbacks, not before.