Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StructuredCloneWithTransfer() usage #1102

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Update StructuredCloneWithTransfer() usage #1102

merged 1 commit into from
Apr 21, 2017

Conversation

domenic
Copy link
Contributor

@domenic domenic commented Apr 4, 2017

Fixes #1089.

@domenic domenic requested a review from jungkees April 4, 2017 06:22
@domenic domenic mentioned this pull request Apr 4, 2017
Merged
@mkruisselbrink
Copy link
Collaborator

Not entirely related to this PR, but the spec for ServiceWorker.postMessage looks not entirely correct. We call "Run Service Worker", which in parallel creates the workers global object, yet postMessage in the next step tries to synchronously access that global (which hasn't been created yet at that point). It seems instead postMessage should synchronously serialize the message, and then queue a task on the worker to actually deliver the message event after the worker has started up?

@jungkees jungkees mentioned this pull request Apr 19, 2017
Closed
@jungkees
Copy link
Collaborator

Filed #1126.

I think we can merge this PR. @domenic, could you rebase it to resolve the conflict?

@domenic domenic force-pushed the fix-structured-clone branch from 173475e to 3d417de Compare April 20, 2017 20:43
@domenic
Copy link
Contributor Author

domenic commented Apr 20, 2017

@jungkees updated

@domenic
Update structured serialization usage and postMessage algorithms
066d0d5 
Fixes w3c#1089 by updating to the latest in structured serialize/deserialize technology, and fixes w3c#1126 by properly deserializing in the queued task instead of ahead of time.
@domenic domenic force-pushed the fix-structured-clone branch from 3d417de to 066d0d5 Compare April 20, 2017 20:46
@domenic domenic mentioned this pull request Apr 20, 2017
Merged
@jungkees jungkees merged commit 884fedb into w3c:master Apr 21, 2017
@jungkees
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jungkees jungkees Awaiting requested review from jungkees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domenic @mkruisselbrink @jungkees