Skip to content

Commit

Permalink
Infrastructure: Enable spellchecking on all files (pull #1585)
Browse files Browse the repository at this point in the history
Makes the following changes to spell checking:
* Removes words that are now part of the base dictionary.
* Expands the check to cover all files, including js.
* Ignores the deleted archive file and third party files.
* Renames some shortened JS variables so they didn't need to be ignored.
* Updates CI path filters to match new ignored files.
  • Loading branch information
nschonni authored Nov 9, 2020
1 parent 142864b commit 2e8bb44
Show file tree
Hide file tree
Showing 43 changed files with 222 additions and 247 deletions.
28 changes: 16 additions & 12 deletions .github/workflows/spelling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,25 @@ on:
branches-ignore:
- "dependabot/**"
paths:
- "package*.json"
- "cspell.json"
- "aria-practices.html"
- "examples/**/*.html"
- ".github/workflows/cspell-problem-matcher.json"
- ".github/workflows/spelling.yml"
- "**/*.*"
- "!**/*.min.js"
- "!**/*.pack.js"
- "!**/*.paint"
- "!aria-practices-DeletedSectionsArchive.html"
- "!examples/landmarks/css/bootstrap.css"
- "!common/**"
- "!respec-config.js"

pull_request:
paths:
- "package*.json"
- "cspell.json"
- "aria-practices.html"
- "examples/**/*.html"
- ".github/workflows/cspell-problem-matcher.json"
- ".github/workflows/spelling.yml"
- "**/*.*"
- "!**/*.min.js"
- "!**/*.pack.js"
- "!**/*.paint"
- "!aria-practices-DeletedSectionsArchive.html"
- "!examples/landmarks/css/bootstrap.css"
- "!common/**"
- "!respec-config.js"

jobs:
spelling:
Expand Down
6 changes: 3 additions & 3 deletions coverage/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ <h1>ARIA Roles, Properties and States Referenced in Guidance and Examples</h1>
<h2>CSV Files of Role, Properties and States Coverage</h2>
<ul>
<li><a href="role-coverage.csv">CSV file of role coverage</a></li>
<li><a href="prop-coverage.csv">CSV file of properies and states coverage</a></li>
<li><a href="prop-coverage.csv">CSV file of properties and states coverage</a></li>
</ul>
</section>

Expand Down Expand Up @@ -105,7 +105,7 @@ <h2 id="roles_with_one_example_label">Roles with at Least One Guidance or Exampl
</tr>
<tr>
<td><code>complementary</code></td>
<td><a href="../aria-practices.html#aria_lh_complemtary">Complementary</a>
<td><a href="../aria-practices.html#aria_lh_complementary">Complementary</a>
</td>
<td><a href="../examples/landmarks/complementary.html">Complementary Landmark</a>
</td>
Expand Down Expand Up @@ -1081,4 +1081,4 @@ <h2 id="props_with_more_than_one_label">Properties and States with More than One
</nav>


</main></body></html>
</main></body></html>
94 changes: 31 additions & 63 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,19 @@
"dictionaries": [
"html",
"css",
"javascript"
"javascript",
"npm"
],
"words": [
"activedescendant",
"affordance",
"ahederson",
"alertdialog",
"amet",
"Anjou",
"Aristov",
"assistive",
"avacmd",
"AXAPI",
"Balusani",
"beingpractical",
"Bellew",
"Biblio",
"Bijl",
"blahblah",
"blahblahblah",
"Bocoup",
"Bohrium",
"Bookmarklet",
Expand All @@ -31,40 +25,35 @@
"Bucketwheat",
"Capitan",
"Carron",
"Checkboxes",
"Chjat",
"cloque",
"colcount",
"colheader",
"colindex",
"Colom",
"columnheader",
"Combobox",
"comboboxes",
"commenters",
"consectetur",
"contenteditable",
"Contentinfo",
"Cook'n",
"Copernicium",
"Coughlin",
"crossorigin",
"cufc",
"Cundiff",
"Cutey's",
"Dahamiwal",
"Darmstadtium",
"datepicker",
"Davoust",
"Defocus",
"Deque",
"describedby",
"DHTML",
"dialog's",
"dijit",
"Dimas",
"discoverability",
"Dmuddy",
"docx",
"dropup",
"Dubnium",
"Dušek",
"EXPANDO",
"Fairchild",
"Fancytree",
"Fentress",
Expand All @@ -78,39 +67,32 @@
"Gaelle",
"Garaventa",
"Geppy",
"gridcell",
"gridcells",
"GUIs",
"Gunderson",
"haspopup",
"Hassium",
"Hausler",
"Higley",
"Hillen",
"hljs",
"Hoyt",
"IDREF",
"IDREFS",
"imadeadcatsadly",
"imgs",
"Iskandar",
"issie",
"Jaeun",
"jarosewli",
"Jinyuan",
"Jèrôme",
"Jinyuan",
"Kasper",
"kbdshortcuts",
"keyshortcuts",
"kittenseason",
"Kowno",
"labelledby",
"Lauke",
"Leventhal",
"Lewandowski",
"Listbox",
"listbox's",
"Listboxes",
"listitem",
"Livermorium",
"Malo",
"Manish",
Expand All @@ -119,10 +101,7 @@
"menubars",
"Menubutton",
"menubuttons",
"menuitemcheckbox",
"menuitemradio",
"menuitems",
"Michiel",
"Minard",
"Minard's",
"Mobilow",
Expand All @@ -131,56 +110,46 @@
"moreaccessible",
"Moscovium",
"MSAA",
"multiselectable",
"multithumb",
"myuniveristy",
"Nemeth",
"Nihonium",
"nofollow",
"nodir",
"norotate",
"Nurthen",
"NVDA",
"Obel",
"Oganesson",
"Okinawans",
"onlosecapture",
"Orscha",
"outdent",
"Paciello",
"PAGEUP",
"perceivability",
"Philipp",
"PIAS",
"Pieters",
"Polovnyov",
"portlet",
"posinset",
"Presentational",
"Pseudocereal",
"radiogroup",
"Rearrangeable",
"recursing",
"refreshable",
"repo",
"respec",
"Roentgenium",
"rowcount",
"rowgroup",
"rowheader",
"rowindex",
"rtrim",
"Rudloff",
"rufflazydogs",
"Sakura",
"Sanaullah",
"Scheuhammer",
"Schonning",
"screenreader",
"Scrollable",
"Seaborgium",
"Seckel",
"selectable",
"setsize",
"Ségur",
"Shirisha",
"shizzle",
"Shopify",
"sidepanel",
"signup",
"Smorgeni",
"Spinbuttons",
"Starkrimson",
Expand All @@ -189,42 +158,34 @@
"submenu's",
"submenus",
"Sulaiman",
"Ségur",
"tabbable",
"tabindex",
"tablist",
"tablists",
"tabpanel",
"Tatiana",
"Tennessine",
"textfield",
"Thaarup",
"thegoogle",
"Thiel",
"Thiers",
"thomascorthals",
"transactinide",
"transuranic",
"Transuranium",
"treegrid",
"Treegrids",
"treeitem",
"Treeview",
"Tryens",
"uncheck",
"Unchecking",
"unchecks",
"unimp",
"unmanaged",
"valuemax",
"valuemin",
"valuenow",
"valuetext",
"Vasily",
"Vinkle",
"visua",
"vnurc",
"Vyacheslav",
"walkability",
"wascute",
"WCAG",
"widget's",
"Wilna",
"Wirma",
"Witebsk",
Expand All @@ -246,11 +207,18 @@
"aria-labelledby=\"(?:[^\\\"]+|\\.)*\"",
"aria-owns=\"(?:[^\\\"]+|\\.)*\"",
"href=\"(?:[^\\\"]+|\\.)*\"",
"for=\"(?:[^\\\"]+|\\.)*\"",
"data-(.*[=> ]?)"
"for=\"(?:[^\\\"]+|\\.)*\""
],
"allowCompoundWords": true,
"ignorePaths": [
"**/*.min.js",
"**/*.pack.js",
"**/*.paint",
"aria-practices-DeletedSectionsArchive.html",
"examples/landmarks/css/bootstrap.css",
"common/**",
"node_modules/**"
"node_modules/**",
"package*.json",
"respec-config.js"
]
}
8 changes: 4 additions & 4 deletions examples/carousel/js/carousel-prev-next.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,16 +94,16 @@ var CarouselPreviousNext = function (node, options) {
// Carousel item events

for (var i = 0; i < this.carouselItemNodes.length; i++) {
var caouselItemNode = this.carouselItemNodes[i];
var carouselItemNode = this.carouselItemNodes[i];

// support stopping rotation when any element receives focus in the tabpanel
caouselItemNode.addEventListener('focusin', this.handleFocusIn.bind(this));
caouselItemNode.addEventListener(
carouselItemNode.addEventListener('focusin', this.handleFocusIn.bind(this));
carouselItemNode.addEventListener(
'focusout',
this.handleFocusOut.bind(this)
);

var imageLinkNode = caouselItemNode.querySelector('.carousel-image a');
var imageLinkNode = carouselItemNode.querySelector('.carousel-image a');

if (imageLinkNode) {
imageLinkNode.addEventListener(
Expand Down
2 changes: 1 addition & 1 deletion examples/carousel/js/carousel-tablist.js
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ CarouselTablist.prototype.handleTabpanelFocusOut = function () {
this.hasFocus = false;
};

/* Iniitalize Carousel Tablists and options */
/* Initialize Carousel Tablists and options */

window.addEventListener(
'load',
Expand Down
2 changes: 1 addition & 1 deletion examples/combobox/js/combobox-autocomplete.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ ComboboxAutocomplete.prototype.getNextOption = function (currentOption) {
/* MENU DISPLAY METHODS */

ComboboxAutocomplete.prototype.doesOptionHaveFocus = function () {
return this.combobocNode.getAttribute('aria-activedescendant') !== '';
return this.comboboxNode.getAttribute('aria-activedescendant') !== '';
};

ComboboxAutocomplete.prototype.isOpen = function () {
Expand Down
2 changes: 1 addition & 1 deletion examples/combobox/js/grid-combo-example.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var FRUITS_AND_VEGGIES = [
['Olive', 'Vegetable'],
['Onion', 'Vegetable'],
['Orange', 'Fruit'],
['Parship', 'Vegetable'],
['Parsnip', 'Vegetable'],
['Pea', 'Vegetable'],
['Pear', 'Fruit'],
['Pineapple', 'Fruit'],
Expand Down
Loading

0 comments on commit 2e8bb44

Please sign in to comment.